fix: refactor process aggregation to a shared core reader - #132
Merged
cdsap merged 1 commit intoSep 17, 2026
Merged
Conversation
cdsap
deleted the
issue/131-hermes-refactor-process-aggregation-to-a-sh-a1
branch
September 17, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
DevelocityWrapperConfiguration.kt and InfoKotlinProcessBuildService.kt independently construct ConsolidateProcesses and apply TypeProcess.Kotlin, duplicating core behavior inside infrastructure adapters.
Why this matters
The aggregation rule can drift between console and Build Scan output, and direct parser coupling makes the core behavior harder to unit test independently.
Proposed change
Introduce a small KotlinProcessReader that owns process consolidation and Kotlin filtering. Inject or call it from both reporting adapters while preserving provider evaluation timing and output behavior.
Notes
This creates a narrow domain boundary: process aggregation is core behavior, while console and Develocity classes remain infrastructure adapters. Current validation: ktlintCheck passes; test currently reports 8 failures in InfoKotlinProcessPluginTest before any refactor.
Fixes #131
Changes
src/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollector.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessReader.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollectorTest.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessReaderTest.ktVerification
./gradlew ktlintCheck./gradlew test